search

jfarmer08 / homebridge-wyze-smart-home

Wyze Smart Home plugin for Homebridge.
MIT License
103 stars 17 forks source link

Thermostat Beta Update #68

Closed carTloyal123 closed 1 year ago

carTloyal123 commented 1 year ago

Updated Thermostat implementation that had some broken merge conflicts in it.

carTloyal123 commented 1 year ago

@jfarmer08 this should be a good beta version to merge.

jfarmer08 commented 1 year ago

Not trying to be a pain, but your branch is base on the rebase. Since there are so many changes in that and it's more of a playground at this point could you make a copy of what you have and then pull my dev branch down. From there create a branch from it. So when you do a pull request we only see the changes you have for the thermostat. If that does not makes sense let me know.

jfarmer08 commented 1 year ago

I don't mind doing it, but I would like to give you credit for this.

carTloyal123 commented 1 year ago

Ah I see, yeah I had merged it all a little chaotic and it did not come out correctly. I will have it up tomorrow then.

carTloyal123 commented 1 year ago

@jfarmer08 things should be good to go now, let me know if there is still an issue!

jfarmer08 commented 1 year ago

Looks good. I will merge this tonight