jfc3 / 10kapart

First commit for my 10K Apart entry.
0 stars 0 forks source link

Remove Asterisks from Restaurants Not Eaten at Yet #105

Closed jfc3 closed 7 years ago

jfc3 commented 7 years ago

Need to remove asterisks from restaurants not eaten at yet once #104 is completed and working. Will need to publish the updates to PROD server once they both are complete so we don't get duplicate sets of asterisks.

jfc3 commented 7 years ago

My thinking is I should add a flag/field called "eaten" and if so add the word "yes" which will not show asterisks and if empty or anything else will get and asterisks placed after the restaurant's name and not part of the link. The asterisk will have aria-describedby added, so it will tell assistive technology users that these are places I have not yet eaten at yet.

jfc3 commented 7 years ago

Need to work on and complete with issues #84 and #104.

jfc3 commented 7 years ago

In preparation to add eaten here, photo, and ALT text code I'm adding the following fields for all these JSON files:

JSON City Files

jfc3 commented 7 years ago

Being that this repository is the same as the ATE HERE one only with smaller JSON file sizes to keep the total page load below 10K, I have stopped doing double the work.

If you want to see, the application working live go to John F Croston III Ate Here.

There will be no further code updating at this time unless I try something crazy and don't want to mess with the live version.

Closing out all the open issues too.