search

jfcabana / omg_dosimetry

Optimized Multichannel Gafchromic Dosimetry
https://omg-dosimetry.readthedocs.io/en/latest/
MIT License
8 stars 2 forks source link

Error on the Publish Python distribution to PyPI and TestPyPI Action #38

Open jfcabana opened 11 months ago

jfcabana commented 11 months ago

The "Sign the Python Distribution" job is returning the following error: image

jfcabana commented 11 months ago

Additionnally, I can see that the current release on Github is 1.5.1

I thought the Action would automatically create a release on github along with publication on pypi, but that does not seem to be the case.

LuisOlivaresJ commented 11 months ago

Screenshot from 2023-12-27 12-37-59

It worked :muscle:

jfcabana commented 11 months ago

Yes! Good job!

LuisOlivaresJ commented 10 months ago

guthub release error

The workflow is creating a new release. The name of the release is copied from the name of the branch or tag that triggered the workflow.

By my understanding, in order to avoid an error in future pull requests, we need to add a tag (on the branch you want to merge into OMG_master) if we want an automatic release on GitHub. I will try to add a line of code to skipt the GitHub-release job if the pull request does not have a tag.

LuisOlivaresJ commented 10 months ago

The last pull request #43 did not resolve this issue. But I am not sure if made a mistake in the order of the Git commands that I wrote 1.- I committed the new line of code, 2.- Pushed the commit to GitHub, 3.- Added a tag, 4.- Pushed the tag to GitHub 5.- Made the pull-request.

i.e. the commit and the tag where made in different push.

Maybe we have to commit, add a tag, and after that push to GitHub (and make a pull request).

Would you like to try? For example:

1.- create a new branch, 2.- change "pyproject.toml" version = "1.6.3" to version = "1.6.4", 3.- commit the change, 4.- add a tag (for example v1.6.4), 5.- push 6.- Make a pull request to OMG_master.