search

jfcere / ngx-malihu-scrollbar

Angular 2+ scrollbar customization using Malihu jQuery Custom Scrollbar plugin
https://jfcere.github.io/ngx-malihu-scrollbar
MIT License
58 stars 17 forks source link

remove jquery dependency in project #28

Closed tamohugues closed 6 years ago

tamohugues commented 6 years ago

Can you provide new version without dependency of jquery in the project ?

because Jquery is not good for angular >= 2 And use only the angular component for the ngx-malihu-scrollbar implementation. We love your work, but we are reluctant to use the module because of the dependency with JQuery. Plz can you update if is possible and remove Jquery dépendency.

jfcere commented 6 years ago

@tamohugues I would if I could ...

I only wrapped an existing library that uses jQuery: https://github.com/malihu/malihu-custom-scrollbar-plugin

The owner would have to rewrite the plugin with pure JS instead of jQuery. If he does I would follow his changes and remove the dependency.

But note that I wrapped every calls to the jQuery library so it could run outside angular change detection process. Although this means pulling on jQuery library it should not be that bad for angular performance.