search

jfcere / ngx-markdown

Angular markdown component/directive/pipe/service to parse static, dynamic or remote content to HTML with syntax highlight and more...
https://jfcere.github.io/ngx-markdown
MIT License
1.07k stars 182 forks source link

marked ^12.0.2 → ^13.0.0 #526

Open sysmat opened 5 months ago

sysmat commented 5 months ago

add support for marked 13

muuvmuuv commented 4 months ago

It really feals like marked does major releases every week haha

sysmat commented 4 months ago

Maybe do range in version dependency 27. jun. 2024 20:17 je oseba Marvin Heilemann @.***> napisala: It really feals like marked does major releases every week haha

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.> [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/jfcere/ngx-markdown/issues/526#issuecomment-2195397457", "url": "https://github.com/jfcere/ngx-markdown/issues/526#issuecomment-2195397457", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

jfcere commented 4 months ago

Marked 13 brings breaking changes and I am following the Angular versioning so I won't update marked until next Angular version.

Due to all the breaking changes, doing range versions is out of the question.

And yeah, marked do update often 😅

kle-pra commented 3 months ago

Marked 14 was just released so probably just try to upgrade to 14 when upgrading with next angular version if possible.

SEQUOiA87 commented 3 months ago

Marked 14 was just released so probably just try to upgrade to 14 when upgrading with next angular version if possible.

Did someone already try this and can confirm whether it's working for Marked 14? Thanks in advance!

muuvmuuv commented 3 months ago

Marked 13 brings breaking changes and I am following the Angular versioning so I won't update marked until next Angular version.

If it breaks something do a major release. That what semver is for. I see no reason to stay on an old peer dep just because of Angular. Create a md-table with which version supports which Angular version. What if marked 13/14/15 has a security fix, do we need to wait for Angular 19/20...? Sry, but I heard that way too often in Angular-Ecosystem