jfcherng-sublime / ST-ASS

ASS/SSA subtitles syntax highlight for Sublime Text.
MIT License
26 stars 2 forks source link

Rewrite syntax definition #4

Closed FichteFoll closed 5 years ago

FichteFoll commented 5 years ago

The ASS syntax defiition always annoyed me because of its wrong scope usage (notably entity.name for style references), so I finally decided to tackle those. And while I was at it I realized I could do a much better job at highlighting, so I implemented a couple new features and more finegrained highlighting comparable to how ASS is actually parsed (by VSFilter).

Here are a few screenshots from an example script:

2019-02-21_17-39-38 2019-02-21_17-43-10

(Ignore the linter errors that I got for free thanks to SublimeLinter.)

See also the extended test file.

I left the commits as I made them because I imagine you'd squash them anyway.

jfcherng commented 5 years ago

A big thanks for this. :+1: I probably would never rewrite it by myself since its "looking" is kind of good enough for me.

Would you mind providing a decent miscellaneous/demo.ass for the purpose of a quick visual view. The current one is just too simple. :laughing:

jfcherng commented 5 years ago

Thank you @FichteFoll :heart: