search

jfcote87 / esign

DocuSign REST API
BSD 3-Clause "New" or "Revised" License
23 stars 27 forks source link

make the properties of width and height to default. #6

Closed simplysivu closed 4 years ago

simplysivu commented 4 years ago

Updated the types of width and height to default for v2.1; removed the overrides for those fields

Refer: https://github.com/jfcote87/esign/issues/5

simplysivu commented 4 years ago

all tests are passing.

simplysivu commented 4 years ago

@jfcote87 are these are valid changes.

simplysivu commented 4 years ago

Hi @jfcote87, Did you get a chance to review this. Am I missing anything?

simplysivu commented 4 years ago

Pushed the changes with suggested fixes.

jfcote87 commented 4 years ago

It looks like you updated your master branch and not the simplysivu:Update-widht-and-height-types. Your changes look good. Thanks.

simplysivu commented 4 years ago

Thank you very much. I updated the branch.