search

jfcoz / postgresqltuner

Simple script to analyse your PostgreSQL database configuration, and give tuning advice
https://postgresqltuner.pl
GNU General Public License v3.0
2.61k stars 190 forks source link

huge_pages only accepts 'on' #54

Closed Arcanemagus closed 5 years ago

Arcanemagus commented 5 years ago

https://github.com/jfcoz/postgresqltuner/blob/a12c432b3af908e964b0285de0ccb6431440102c/postgresqltuner.pl#L607-L612

This bit of code doesn't seem to understand the values for this setting, as described in the documentation for huge_pages the default value of this setting is try, which will use them if available but won't fail to start if they aren't. The recommended value of on will actually prevent the server from starting if there aren't enough pages available!

This should only warn if the value has been explicitly set to off.

natmaka commented 5 years ago

Indeed. I fixed it.

jfcoz commented 5 years ago

Thanks