search

jfdoming / Project-B

MIT License
1 stars 3 forks source link

first version of cutscene engine #35

Closed Telvy closed 4 years ago

Telvy commented 4 years ago

This is the first version that I managed to commit. Is not exactly what I wanted since most of the system is all show but little substance in the code. I may redo the whole system, but keep certain visual elements like the scrolling text and next icon animation. Thoughts?

jfdoming commented 4 years ago

Any status update on this?

rpecka commented 4 years ago

Any status update on this?

Hey, sorry for the late reply. @Telvy is working on a followup to this at the moment. I'm not sure how much of what he is working on now depends on this code but he is new to git so I think the second PR will include everything done in this. We should probably close this.

@Telvy did you use the code in this PR in the new stuff you're working on now? Have you made significant changes to the code in this PR since you submitted it?

Telvy commented 4 years ago

Heyya. Sorry for the late reply. For the past week or so I've been creating a completely new system that has more classes implemented to have the whole system working.

The whole system reads a .json file with information on the respective characters, expressions and lines. Most the code in my first pull request is practically dead at this point. I'll scrap the code for the visual text scrolling affects and that's it.

Also first time comment replying on github. Never did this before but I hope I'm doing this right.

jfdoming commented 4 years ago

@Telvy all good, sounds exciting! Let's close this PR then in favour of the new one.