search

jfedor2 / hid-remapper

USB input remapping dongle
Other
1.12k stars 135 forks source link

Crazy behaviour with rollover/ghosting #70

Open columna1 opened 1 year ago

columna1 commented 1 year ago

Using this HID remapper I sometimes get really weird key repeats and such when typing. I have done some research and have come to the conclusion that this likely has to do with ghosting/rollover sending all 0x01 bytes in the keycode report when there is an error state. This likely causes prev_input_state to be overwritten with all 0x01 or something similar making hid-remapper think the keys are no longer pressed. Then, when the keyboard comes out of error state and sends the rest of the keys currently pressed hid-remapper thinks that all of those keys are pressed sends them all again a second time. this results in things like in colemak the "oul" keys when pressed on a cheap hp keyboard gives an error state. (; I and U keys in qwerty) leading to things like typing "could" resulting in "cououllud" or something similar. I would assume we want to ignore packets that have that error state or at least prevent updating the keyboard state when one is received. I am able to reproduce this when using a proper 6-key rollover keyboard and pressing more than 6 keys.

jfedor2 commented 1 year ago

Good catch!

columna1 commented 12 months ago

I just want to clarify, on some keyboards this can occur when pressing as little as 3 keys at once, it's not just a 6kRO (only) bug. That's why it was an issue with my cheap company provided keyboard at work. I was hitting this when typing normally.

jfedor2 commented 12 months ago

I haven't forgotten about this!

jfedor2 commented 12 months ago

If you still have access to that keyboard and are up for some testing, you can try a test build from here (the artifact link at the bottom):

https://github.com/jfedor2/hid-remapper/actions/runs/6973886250

I'm not sure if it's necessarily the solution I want to go with, but it's one possible solution.

columna1 commented 12 months ago

Sorry for the delay. I've managed to test the firmware you provided and it works great.

jfedor2 commented 10 months ago

The latest official release also contains a (different) fix for this!