search

jfeinstein10 / SlidingMenu

An Android library that allows you to easily create applications with slide-in menus. You may use it in your Android apps provided that you cite this project and include the license in your app. Thanks!
Apache License 2.0
11.07k stars 5.04k forks source link

Drawer indicator icon #424

Open yccheok opened 11 years ago

yccheok commented 11 years ago

Although Google just release http://developer.android.com/design/patterns/navigation-drawer.html#side-nav, I still prefer SlidingMenu as it offers much more customization options. I was wondering, is there any plan to implement "Drawer indicator icon" into SlidingMenu?

JesseFarebro commented 11 years ago

+1 I completely agree with Yan. I much prefer SlidingMenu over googles implementation but the indicator is nice.

jfeinstein10 commented 11 years ago

Right now I'm a little busier than I'd like to be, but I'll definitely be looking at Google's implementation ASAP to pull out what I can (including the indicator hopefully)

yccheok commented 11 years ago

Thanks and looking forward! :+1:

chitgoks commented 11 years ago

another good drawer indicator would be like the kik messenger app. the user will be able to tell that a sliding menu feature is available because of the left most vertical image can indicate it is draggable.

gergely-sallai commented 11 years ago

Looking forward to this update. I think it would be best to stick with google's version of the indicator, that's gonna be a 'standard'.

logyou commented 11 years ago

pretty works:-)

philburtenshaw commented 11 years ago

Hi - is there any news on this - any sort of timeline or the likes?

Maradox commented 11 years ago

Looking forward to this update too. Love the SlidingMenu though

fabriciomassula commented 11 years ago

Looking forward to this update! Will be awesome!

gergely-sallai commented 11 years ago

I have a working implementation of this, it's also ActionBarSherlock compatible. It needs some testing and some clean up though. If I have some spare time I will upload it. I'm fairly new to github so I could use some hint how to send an update request to this repo. (I dont want to fork the entire repo)

gingo commented 11 years ago

+1 for navigation Drawer!

sockeqwe commented 11 years ago

@gergely-sallai On github you have to fork the complete project / repository into your own github account. So the repository gergely-sallai/SlidingMenu will be created. Than you will commit and push your changes to gergely-sallai/SlidingMenu. if you are done with your work and want to "update" your changes to the original repository jfeinstein10/SlidingMenu then you need to create a pull request (there will be a button in gergely-sallai/SlidingMenu on github to do that). Than the original author (jfeinstein10) can accept your pull request and your changes (your commits) are merged automatically into the original repository jfeinstein10/SlidingMenu. Than you can delete your forked repository in you github account, if you want to.

franzvezuli commented 11 years ago

Any new updates on this?

Been researching how to add a Drawer Icon on the top left. Even if it's just an arrow click even that pulls out Sliding menu, that would work too.

sockeqwe commented 11 years ago

I have made a pull request: https://github.com/jfeinstein10/SlidingMenu/pull/516

It will bring a slideable icon that will replace the default up indicator of the ActionBar, like ActionBarDrawerToggle (http://developer.android.com/reference/android/support/v4/app/ActionBarDrawerToggle.html)

yccheok commented 10 years ago

Hi, any update on this issues? As Google's NavigationDrawer don't have proper implementation on

setTouchModeAbove(SlidingMenu.TOUCHMODE_FULLSCREEN);

http://stackoverflow.com/questions/16988597/set-drag-margin-for-android-navigation-drawer/17802569#17802569

hack don't really work especially when its content is ViewPager. When swiping toward left, with NavigationDrawer, ViewPager won't change from view 0 to view 1. All the events are consumed by NavigationDrawer.

But, jfeinstein10 SlidingMenu handles such case gracefully.