Where is rspectacular??

mtasaka commented 7 years ago

I am trying to update Fedora's progressbar to 1.8.2, and progressbar's "spec" test seems to require rspectacular: https://github.com/jfelchner/ruby-progressbar/blob/master/spec/spec_helper.rb#L1

rspectacular 0.70.7's metadata points to https://github.com/jfelchner/rspectacular , which is... 404.

If progressbar's spec test does not need rspectacular any more, would you remove (change) this dependency?
Or progressbar's spec test still needs rspectacular, would you upload rspectacular source (as the developer seems you)?

(Fedora's gem packaging requests that test suite should be executed when packaging gem based rpm, and each package must have proper upstream URL.)

mtasaka commented 7 years ago

By the way, when I install rspectacular 0.70.7 and warning_filter 0.0.6, "rspec spec/" for progressbar 1.8.2 aborts like:

$ rspec spec/
Coverage report generated for RSpec to /home/mtasaka/rpmbuild/fedora-specific/TMP/rubygem-progressbar/master/rubygem-progressbar/1.8.2/TMP/coverage. 319 / 531 LOC (60.08%) covered.
/home/mtasaka/.gem/ruby/gems/rspectacular-0.70.7/lib/rspectacular/plugins/shoulda.rb:11:in `<top (required)>': undefined method `configure' for Shoulda::Matchers:Module (NoMethodError)
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
    from /home/mtasaka/.gem/ruby/gems/rspectacular-0.70.7/lib/rspectacular/plugins.rb:18:in `<top (required)>'
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
    from /home/mtasaka/.gem/ruby/gems/rspectacular-0.70.7/lib/rspectacular.rb:7:in `<top (required)>'
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:127:in `require'
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:127:in `rescue in require'
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:40:in `require'
    from /home/mtasaka/rpmbuild/fedora-specific/TMP/rubygem-progressbar/master/rubygem-progressbar/1.8.2/TMP/spec/spec_helper.rb:1:in `<top (required)>'
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
    from /home/mtasaka/rpmbuild/fedora-specific/TMP/rubygem-progressbar/master/rubygem-progressbar/1.8.2/TMP/spec/ruby-progressbar/base_spec.rb:1:in `<top (required)>'
    from /usr/share/gems/gems/rspec-core-3.5.4/lib/rspec/core/configuration.rb:1435:in `load'
    from /usr/share/gems/gems/rspec-core-3.5.4/lib/rspec/core/configuration.rb:1435:in `block in load_spec_files'
    from /usr/share/gems/gems/rspec-core-3.5.4/lib/rspec/core/configuration.rb:1433:in `each'
    from /usr/share/gems/gems/rspec-core-3.5.4/lib/rspec/core/configuration.rb:1433:in `load_spec_files'
    from /usr/share/gems/gems/rspec-core-3.5.4/lib/rspec/core/runner.rb:100:in `setup'
    from /usr/share/gems/gems/rspec-core-3.5.4/lib/rspec/core/runner.rb:86:in `run'
    from /usr/share/gems/gems/rspec-core-3.5.4/lib/rspec/core/runner.rb:71:in `run'
    from /usr/share/gems/gems/rspec-core-3.5.4/lib/rspec/core/runner.rb:45:in `invoke'
    from /usr/share/gems/gems/rspec-core-3.5.4/exe/rspec:4:in `<top (required)>'
    from /bin/rspec:23:in `load'
    from /bin/rspec:23:in `<main>'

jfelchner commented 7 years ago

@mtasaka the rspectacular repo no longer exists. The source code is in the gem which you can download and inspect if you wish to do that.

Considering that I have ruby-progressbar being built on Travis (which is running Linux) and I build it against every Ruby version since 1.8.7, I'm assuming that it's an issue with your setup and not an issue with the code itself.

pkaeding commented 5 years ago

Can you clarify the license under which rspectacular was released? https://rubygems.org/gems/rspectacular/versions/0.70.7 doesn't list anything, and https://www.rubydoc.info/gems/rspectacular/0.70.7 (as well as the README in the gem) say

rspectacular is Copyright © 2013 The Kompanee. It is free software, and may be redistributed under the terms specified in the LICENSE file.

However, there is no LICENSE file in the gem.

jfelchner commented 5 years ago

@pkaeding MIT. I'll see about updating the LICENSE file but rspectacular is not required for the gem to run.

pkaeding commented 5 years ago

Thanks. I am not actually using ruby-progressbar, but I wasn't sure how else to ask, and found this issue. It was flagged by our source code license audit tool as not having a license.

On Wed, Feb 6, 2019, 2:23 PM Jeff Felchner <notifications@github.com wrote:

@pkaeding https://github.com/pkaeding MIT. I'll see about updating the LICENSE file but rspectacular is not required for the gem to run.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jfelchner/ruby-progressbar/issues/123#issuecomment-461212075, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA2f5JDovnSBl0Nsz9Wr_zSfrW0T5y4ks5vK1X3gaJpZM4Lr6XC .

jfelchner commented 5 years ago

@pkaeding your audit tool flags for development dependencies? That seems odd.

pkaeding commented 5 years ago

Well, our audit tool doesn't differentiate between dev dependencies and runtime dependencies (this is one of its many deficiencies, I'm afraid). I have seen some opinions online that GPL in a test dependency may infect the main code, though IANAL, so I don't know the nuances there.

On Wed, Feb 6, 2019 at 9:39 PM Jeff Felchner notifications@github.com wrote:

@pkaeding https://github.com/pkaeding your audit tool flags for development dependencies? That seems odd.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jfelchner/ruby-progressbar/issues/123#issuecomment-461294871, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA2fwUiFj18W-spjOAwIbHEBrswi1j2ks5vK7wlgaJpZM4Lr6XC .

-- Patrick Kaeding patrick@kaeding.name

jamiehodge commented 5 years ago

This is also a problem for us. It would be great if you could remove/replace this dependency.

jfelchner commented 5 years ago

@jamiehodge @pkaeding @mtasaka I'll release one new version of rspectacular with a LICENSE file just for you all. But it will not be available on Github.

jfelchner commented 5 years ago

@jamiehodge @mtasaka @pkaeding Version 0.70.8 of rspectacular should contain an MIT LICENSE file for you.

https://rubygems.org/gems/rspectacular/versions/0.70.8

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

jfelchner / ruby-progressbar

Where is rspectacular?? #123