jfelchner / ruby-progressbar

Ruby/ProgressBar is a text progress bar library for Ruby.
MIT License
1.58k stars 132 forks source link

Test failure with ruby-progressbar 1.0.1 #21

Closed graaff closed 12 years ago

graaff commented 12 years ago

Using ruby 1.8.7 (2012-06-29 patchlevel 370) [x86_64-linux] I'm getting the following two test failures with ruby-progressbar 1.0.1:

Failures:

  1) ProgressBar::Time#now when Time is being mocked by Timecop retrieves the unmocked Timecop time
     Failure/Error: subject { ProgressBar::Time.now ::TimeMockedWithTimecop }
       (<TimeMockedWithTimecop (class)>).now(no args)
           expected: 0 times
           received: 1 time
     # ./lib/progress_bar/time.rb:6:in `send'
     # ./lib/progress_bar/time.rb:6:in `old_now'
     # ./spec/../spec/support/timecop.rb:16:in `now'
     # ./spec/progress_bar/time_spec.rb:20
     # ./spec/progress_bar/time_spec.rb:26

  2) ProgressBar::Time#now when Time is being mocked by Delorean retrieves the unmocked Delorean time
     Failure/Error: subject { ProgressBar::Time.now ::TimeMockedWithDelorean }
       (<TimeMockedWithDelorean (class)>).now(no args)
           expected: 0 times
           received: 1 time
     # ./lib/progress_bar/time.rb:6:in `send'
     # ./lib/progress_bar/time.rb:6:in `old_now'
     # ./spec/../spec/support/timecop.rb:16:in `now'
     # ./spec/progress_bar/time_spec.rb:31
     # ./spec/progress_bar/time_spec.rb:37

Finished in 0.82176 seconds
102 examples, 2 failures
jfelchner commented 12 years ago

Thanks for the detailed issue. It's passing on Travis so I'm assuming it's something minor. I'll take a look in a couple days.

betelgeuse commented 12 years ago

@jfelchner it's not passing on travis

https://travis-ci.org/#!/jfelchner/ruby-progressbar/jobs/2629766

jfelchner commented 12 years ago

@betelgeuse That's correct. It seems that something which was previously passing has intermittently begun to fail. I'm going to be taking a look this weekend.

jfelchner commented 12 years ago

This has been fixed here: 92355e2

It passed here: https://travis-ci.org/#!/jfelchner/ruby-progressbar/builds/2701170

@graaff Thanks for bringing it to my attention.

graaff commented 12 years ago

Thanks! Confirming that tests now pass on all ruby versions we have in Gentoo Linux.

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.