fix typo and add newline to error messages

jfeliu007 / goplantuml

PlantUML Class Diagram Generator for golang projects

MIT License

1.84k stars 172 forks source link

fix typo and add newline to error messages #94

Closed MorrisLaw closed 4 years ago

MorrisLaw commented 4 years ago

This PR addresses issue #93:

appends a newline to the following error message paths
- could not find directory
- is not a directory
fixes typo with output, goplantum -> goplantuml

jfeliu007 commented 4 years ago

Thanks @MorrisLaw . I'll take a look at the PR now.

jfeliu007 commented 4 years ago

Actually, unfortunately I didn't notice before, but this breaks the build because it fails at Lint. Error messages should never finish with a new line. A better approach should be to add the new line when we are printing the error out to the user in the command. Rather than modifying the error itself. Would you mind redoing this? Line 89 and line 96 are examples of what I changing it at print out.

MorrisLaw commented 4 years ago

Ahh good point @jfeliu007, that was an oversight on my end. I've made this PR: https://github.com/jfeliu007/goplantuml/pull/96 to address #93 . Should be good now 👍