search

jfelten / gitea-helm-chart

MIT License
76 stars 66 forks source link

Do not overwrite app.ini if it exists in PV #43

Closed paulgrahek closed 4 years ago

paulgrahek commented 4 years ago

Reintroduce app.ini persistence per issue #38.

A question on how this should be implemented: Should the app.ini file be left completely alone after it is first created, or should certain values such as the postgres password (as was present previously) and other configuration options that are set in values.yaml for the app.ini file be updated as well on helm install and helm upgrade? It becomes a tedious task to manually update values present in values.yaml within the app.ini file otherwise.

couillonnade commented 4 years ago

Would you accept a PR for mariadb password upgrade if app.ini exists? It would be possible to upgrade helm and keep the password in k8s secrets instead of hardcoding the password in values.yaml.