search

jferard / fastods

A very fast and lightweight (no dependency) library for creating ODS (Open Document Spreadsheet, mainly for Calc) files in Java. It's a Martin Schulz's SimpleODS fork
GNU General Public License v3.0
36 stars 6 forks source link

Adds OSGi Support #190

Closed juergen-albert closed 4 years ago

juergen-albert commented 4 years ago

While I was on it, I saw the import of the NoImplementationException and took the liberty of replacing it with the UnsupportedOperationException. Using such internal java Classes binds the library to an oracle JDK and can cause problems with higher java Versions, where they may already have removed it.

One sidenote for the future:

OSGi makes a distinction between internal packages and exported API. The CData section configures it to Mark each Package that fits com.github.jferard.fastods.* as public API. So you are fine, if you add new packages that fit this schema. If you add new Packages like e.g. com.github.jferard.common, and they are not only used internally, it would be great if you would add them with a comma as separator example would be:

<![CDATA[
   Export-Package: com.github.jferard.fastods.*, com.github.jferard.common
]]>

or (if you want a line break)

<![CDATA[
    Export-Package: com.github.jferard.fastods.*, \
        com.github.jferard.common
]]>
jferard commented 4 years ago

Thanks!