search

jferard / fastods

A very fast and lightweight (no dependency) library for creating ODS (Open Document Spreadsheet, mainly for Calc) files in Java. It's a Martin Schulz's SimpleODS fork
GNU General Public License v3.0
36 stars 6 forks source link

Make XXXUtil methods static #198

Closed jferard closed 3 years ago

jferard commented 4 years ago

I wanted to keep them "mockable", but they are not mocked anywhere. Are they derived?

This would alleviate signatures.

jferard commented 3 years ago

Classes are :

But XMLUtil depends on the XMLEscaper and has a cache. XMLUtil methods are not "so" pure that they can be made static.

jferard commented 3 years ago

I'm closing because this is not a good idea because the static methods become viral. That's not how FastODS was designed.