search

jferard / fastods

A very fast and lightweight (no dependency) library for creating ODS (Open Document Spreadsheet, mainly for Calc) files in Java. It's a Martin Schulz's SimpleODS fork
GNU General Public License v3.0
36 stars 6 forks source link

Improve Excel compatibility #212

Closed ueen closed 3 years ago

ueen commented 3 years ago

I tried to changed as little as possible, not to break anything, i've documented my findings here https://github.com/jferard/fastods/issues/142#issuecomment-720137421 and can now open files with Google Sheets (Android), Excel 2016 and LibreOffice 7.0 without any errors apearing, this might not be the case for more complicated tables but with simple String values this is what i tested, other Excel and prior LibreOffice versions probably work as well, but i didn't check.

jferard commented 3 years ago

Thanks for this PR. I saw you fixed VerticalAlign and it compiles now, that's good. There are a bunch of test failures, but that's not really an issue for the moment, since some tests are just there to ensure that if the XML changes, you know where.

I will make some comments on the files changed.