Move StyleTag to StylesEntry

jferard / fastods

A very fast and lightweight (no dependency) library for creating ODS (Open Document Spreadsheet, mainly for Calc) files in Java. It's a Martin Schulz's SimpleODS fork

GNU General Public License v3.0

36 stars 6 forks source link

Move StyleTag to StylesEntry #24

Closed jferard closed 7 years ago

jferard commented 7 years ago

The StyleTag XML is written in content.xml > automatic-styles. That's the wrong destination, since FastODS does not allow anonymous styles. The output has to be moved to styles.xml > styles.

jferard commented 7 years ago

There are a lot of problems with that commit:

LO does not recognize common styles for rows, columns or text spans.
LO does not accept text family styles for page layout if those styles are not in Styles/automatic-styles.
A few other limitations.

A good rule of thumb: follow LO if possible, even if LO does not fully respect the specs.

jferard commented 7 years ago

Fixed with the StylesContainer class, which centralizes the style definitions. Entries use it to write styles XML in the suitable place.