Use a specific FullList for raw types

jferard / fastods

A very fast and lightweight (no dependency) library for creating ODS (Open Document Spreadsheet, mainly for Calc) files in Java. It's a Martin Schulz's SimpleODS fork

GNU General Public License v3.0

36 stars 6 forks source link

Use a specific FullList for raw types #27

Closed jferard closed 7 years ago

jferard commented 7 years ago

A basic implementation of a list of bytes or ints with 0 as default value would probably be faster than an ArrayList<Integer> with auto boxing/unboxing, and would avoid the the problem of null values. Need some profiling to determine if it worths it.

jferard commented 7 years ago

Results of the profiling the creation of a 80000 rows / 40 columns file, in self time (percent):

XMLUtil.appendEAttribute: 26.6%
FullList : 20.1%
ZipUTF8Writer.append: 6.1% A custom implementation woud be welcome and not really difficult to implement.

jferard commented 7 years ago

There are only two lists of integers (columnsSpanned and rowsSpanned) and no list of bytes. The FullIntList is available in util package, but won't be used now.