jfernandez / ControllerTools

Game controller plugin for the Steam Deck
GNU General Public License v3.0
53 stars 3 forks source link

Cannot read property #43

Closed dm82m closed 4 months ago

dm82m commented 6 months ago

With current steam beta client and pre release of decky it raises an TypeError Cannot read properties.

I guess it has something todo with: https://github.com/mcarlucci/decky-storage-cleaner/pull/10

TiZ-HugLife commented 6 months ago

DFL needs to be bumped. See this specific comment of SteamDeckHomebrew/decky-loader#597. Thanks for your time.

TiZ-HugLife commented 4 months ago

It's not happening "again", it's just still happening. All the breaking changes from beta got shoved out into stable, so now everything with Decky is everyone's problem.

jfernandez commented 4 months ago

I'll look into updating DFL

jfernandez commented 4 months ago

controller-tools-1.2.0.zip

Could one of you manually install this release candidate to see if it fixes the problem?

costinvader commented 4 months ago

This is what it says with that zip file installed 20240508_194317

vbali commented 4 months ago

This is what it says with that zip file installed !

I'm experiencing the same issue with that zip file installed. Have you been able to find a solution or workaround?

costinvader commented 4 months ago

I'm not a developer, I just tested it, sorry bro

jfernandez commented 4 months ago

I'm going to ask in their discord why you are still getting that error.

f3bandit commented 4 months ago

controller-tools-1.2.0.zip

Could one of you manually install this release candidate to see if it fixes the problem?

not fixed

Nachtfrische commented 4 months ago

The error I'm getting with version 1.2.0 is:

TypeError: plugin_export is not a function
       at PluginLoader.importReactPlugin (http://localhost:1337/frontend/chunk-ecb27f3b.js:6995:30)
       at async PluginLoader.importPlugin (http://localhost:1337/frontend/chunk-ecb27f3b.js:6969:17)

I quickly looked at your DFL update and it looked fine to me. Any idea on what else might cause this?

jfernandez commented 4 months ago

I’m out of ideas. I’ve also asked in the Decky discord and they also believe the update looks good. I could use some help debugging this further if anyone wants to help out.

costinvader commented 4 months ago

If this helps, the notification when the battery drops under 15% is still working, only the interface to see what's the actual battery level of the controller is not working

Nottinghster commented 4 months ago

Well, what's missing to be updated or released ? It's a great plugin/feature and we all miss that :)

ecogice commented 4 months ago

according to aagaming on decky discord you dont need output.name in rollup.config.js, remove the line name: "ControllerTools", in the release candidate and see if that fixes it

jfernandez commented 4 months ago

I removed that line from rollup.config.js. Here is the new release candidate. Please give it a try:

controller-tools-1.2.0.zip

Nottinghster commented 4 months ago

I removed that line from rollup.config.js. Here is the new release candidate. Please give it a try:

controller-tools-1.2.0.zip

Now it's working again ❤ screenshot

ecogice commented 4 months ago

yup works :) plugin wasnt showing up when i tried to build manually but all i had to do is delete the settings json for controllertools and reinstall decky

jfernandez commented 4 months ago

Thanks for verifying. It looks like there is a small regression with the Refresh button, but since it's cosmetic I'll go ahead and release 1.2.0 with the fix.