exception error in run() using after option

[GoogleCodeExporter]

What steps will reproduce the problem?
In the code shown in issue ID 30, build3 in FAB.py still causes exception.
# ./FAB.py -j 3 build3
Error: exception <type 'exceptions.AttributeError'> at line 824
Error: unexpected results handler exit

What version of the product are you using? On what operating system?
fabricate 1.24
Python 2.6.6
Linux (SL 5.8)

Please provide any additional information below.

It seems that this is due to the error of instance check around line 824
I would like to suggest a patch (including patch for issue ID 30) to correct it.

In spite of this modification, there is an error remains.
Please consider the following code, for example
  run('job1.sh', group='job1') # assigned to 'job1' group immediately
  run('job2.sh', after='job1') # assigned to False group firstly
                               # and then re-assigned to True group
                               #   after job1.sh finished
  after()                      # wait 'job1' and False groups only
                               # (True group is not listed yet)
In this case, after() cannot catch the finish of job2.sh.
This issue causes incomplete output of .deps file, etc.

Original issue reported on code.google.com by Aoki.Takaaki on 24 Aug 2012 at 2:06

Attachments:

• patch.r2.txt

[GoogleCodeExporter]

I would like to submit a patch for the solution for above problem.

the meaning of _Groups.value.count is extended to include the number of 
commands which are assigned False group firstly, but will be moved to this 
group.

Original comment by Aoki.Takaaki on 24 Aug 2012 at 6:33

Attachments:

• patch.r22.txt

[GoogleCodeExporter]

Patch applied. Will be available in the next update.

Original comment by simon.al...@gmail.com on 3 May 2013 at 11:12

• Changed state: Started

[GoogleCodeExporter]

Fixed in version 1.26 (soon to be pushed)

Original comment by simon.al...@gmail.com on 22 Jul 2013 at 9:41

• Changed state: Fixed