jfgailleur / fabricate

Automatically exported from code.google.com/p/fabricate
0 stars 0 forks source link

[PATCH] Fixes for parallel build errors #36

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Apply patch from issue 30
2. Apply patch from issue 31
3. Down the FAB.py and auto.sh test program from issue 30
4. Run FAB.py

What is the expected output? What do you see instead?

I expect to see the list of commands printed instead I occasionally get the 
following error (among others):

Error: exception <type 'exceptions.AttributeError'> at line 836

In my code base this corresponds to the "while not _stop_results.isSet():" 
statement in the _results_handler function.  The two other errors were with the 
"_groups.set_ok(False)" and "if isinstance(a.do, tuple):" lines in that same 
function.

What version of the product are you using? On what operating system?

32bit
OpenSUSE 11.1
Python 2.6

Please provide any additional information below.

I have attached a path fixing these bugs that prevented me from using the 
parallel building mode.  The first issue was fixed by explicitly waiting for 
the _results_handler thread to stop when exiting.  The other two were single 
line fixes.

Original issue reported on code.google.com by jli...@gmail.com on 28 Feb 2013 at 8:46

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks, jlisee. I'll take a look at these and see about applying them in the 
next couple of days.

Original comment by benh...@gmail.com on 28 Feb 2013 at 9:01

GoogleCodeExporter commented 9 years ago
Patch applied. Will be available in the next update.

Original comment by simon.al...@gmail.com on 3 May 2013 at 11:27

GoogleCodeExporter commented 9 years ago
Fixed in version 1.26 (soon to be pushed)

Original comment by simon.al...@gmail.com on 22 Jul 2013 at 9:41