search

jfgailleur / fabricate

Automatically exported from code.google.com/p/fabricate
0 stars 0 forks source link

Python3 support #38

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. attempt to import or run fabricate with python 3+

I wasn't necessarily expecting Python3 (python 3, py3k, whatever) to be 
supported, but am working on making a codebase that *uses* fabricate 
Python3-compatible.

I'm using fabricate 1.25 on both OSX and Linux with Python 3.3.0.

Attached is a patch that works for my uses but is probably not exhaustive.

Original issue reported on code.google.com by daniel.b...@gmail.com on 7 Apr 2013 at 1:39

Attachments:

GoogleCodeExporter commented 9 years ago 
Nice! I definitely think it's a good idea to make fabricate support Python 3, 
and to do so with a single codebase. I like the "from __future__" approach 
here, and even if there are a couple of "if PY3K"s, that's better than 
supporting two codebases.

Original comment by benh...@gmail.com on 7 Apr 2013 at 3:07

GoogleCodeExporter commented 9 years ago 
I accidentally left a huge amount of stuff out of this patch.  No idea what 
happened there.  Anyway, I'm going to be keeping a git clone + branch going 
over here as I re-add the necessary bits: 
https://github.com/meatballhat/fabricate/tree/py3k-compat

Original comment by daniel.b...@gmail.com on 7 Apr 2013 at 2:10

GoogleCodeExporter commented 9 years ago 
Assuming my master branch is up to date, here's the comparison view for quick 
reference: https://github.com/meatballhat/fabricate/compare/py3k-compat

Original comment by daniel.b...@gmail.com on 7 Apr 2013 at 2:11

GoogleCodeExporter commented 9 years ago 
Imported the changes from git hub. Will merge with master and test.

Original comment by simon.al...@gmail.com on 3 May 2013 at 1:24

GoogleCodeExporter commented 9 years ago 
:thumbsup: and yay!

Original comment by daniel.b...@gmail.com on 3 May 2013 at 1:26

GoogleCodeExporter commented 9 years ago 
Any update on this? Python3 is getting standard now.

Original comment by wber...@google.com on 10 Apr 2014 at 8:16

GoogleCodeExporter commented 9 years ago 
I've rebased the py3k branch on master, dropped a bad commit, and added more 
fixes: https://github.com/Changaco/fabricate/compare/master...py3k-compat

Original comment by chang...@gmail.com on 16 Feb 2015 at 1:23