Allow using a function to set cache-control headers

jfhbrook / node-ecstatic

A static file server middleware that works with core http, express or on the CLI!

https://github.com/jfhbrook/node-ecstatic

MIT License

975 stars 194 forks source link

Closed TehShrike closed 9 years ago

TehShrike commented 9 years ago

Fixes #94

I didn't see any tests involving cache-control or I would have added to them.

jfhbrook commented 9 years ago

It's a gap in the test coverage.

TehShrike commented 9 years ago

If it works, are you willing to merge this without more tests, or do you want to see some tests for cache headers first?

TehShrike commented 9 years ago

Let me know if I can do anything to make this more mergable.

jfhbrook commented 9 years ago

Hey, sorry.

Current status: I've been trying to decide if I'm gonna write tests for this or not.

TehShrike commented 9 years ago

No worries! Let me know what you decide. If I get a chance before you make your move, I may try my hand at it myself.

TehShrike commented 9 years ago

I pushed up some tests for the cache option, let me know how you feel about them!

jfhbrook commented 9 years ago

Published as 1.2.0

Sorry for the long wait!

TehShrike commented 9 years ago

w00t!