jfhbrook / node-ecstatic

A static file server middleware that works with core http, express or on the CLI!
https://github.com/jfhbrook/node-ecstatic
MIT License
975 stars 194 forks source link

[test][fix] Set "Connection: close" header on malformed test request. #171

Closed mk-pmb closed 8 years ago

mk-pmb commented 8 years ago

Fixes #170, a test timeout due to dangling listeners.

mk-pmb commented 8 years ago

No idea why github doesn't pick up my edit conflict resolution. I'll retry the PR.

mk-pmb commented 8 years ago

2nd attempt (redone from scratch) doesn't seem to avoid the merge conflict either. I hope you can still merge it somehow.

dotnetCarpenter commented 8 years ago

@jfhbrook can not merge in a pull request that is not based of the master branch. You need to pull from the master branch and then create a branch from that, before you make your changes.

mk-pmb commented 8 years ago

Edit: Now that I see the commit hashes my git merged, I think I messed up the clone-ing in the first place. I'll try again. Edit 2: I checked out 0151005 now, and with that, the "malformed" tests do succeed, so this PR is obsolete. Sorry for the buzz.