jfhbrook / node-ecstatic

A static file server middleware that works with core http, express or on the CLI!
https://github.com/jfhbrook/node-ecstatic
MIT License
975 stars 194 forks source link

Fix redirections on Windows #261

Open Xmader opened 5 years ago

Xmader commented 5 years ago

Thank you for fixing Backport Open Redirect vulnerability, but it breaks on Windows machines.

path.normalize("/path/to/file") returns \path\to\file on Windows, and it doesn't work in browsers.

codecov-io commented 5 years ago

Codecov Report

Merging #261 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   75.26%   75.26%           
=======================================
  Files          11       11           
  Lines         558      558           
  Branches      128      128           
=======================================
  Hits          420      420           
  Misses         51       51           
  Partials       87       87
Impacted Files Coverage Δ
lib/ecstatic.js 72.36% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ae7a39b...4d75eef. Read the comment docs.

Xmader commented 5 years ago

https://github.com/jfhbrook/node-ecstatic/issues/262

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.26%. Comparing base (ae7a39b) to head (4d75eef). Report is 4 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #261 +/- ## ======================================= Coverage 75.26% 75.26% ======================================= Files 11 11 Lines 558 558 Branches 128 128 ======================================= Hits 420 420 Misses 51 51 Partials 87 87 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.