search

jfhbrook / pyee

A rough port of Node.js's EventEmitter to Python with a few tricks of its own
https://github.com/jfhbrook/public
MIT License
362 stars 37 forks source link

chore: minimum Python version fixes #124

Closed mxschmitt closed 1 year ago

mxschmitt commented 1 year ago

Hi!

The mentioning of Python 3.5 in the readme was confusing, see https://github.com/conda-forge/pyee-feedstock/pull/23#discussion_r1233394781. So I think the best is to remove it.

This patch fixes also the classifiers and adds requires-python into the pyproject.yaml file.

jfhbrook commented 1 year ago

Oh hey, thanks a bunch! This looks great, I'll make sure that i's are dotted and merge this shortly.

In the meantime, I wanted to offer some historical context on the "3.5+" line. When I started this project however many years ago, the common versions of Python were 3.6 and 3.7, with some legacy installs having 3.5 or even 3.4. Because 3.4 didn't have async/await, I wanted to make sure that detail was documented. Of course, time flies, and now all of those versions of Python are obsolete. I kept the documentation because it wasn't not true! But I agree with you that, in a world where almost nobody has 3.4 installed, it only really stands to confuse.

As far as the classifiers goes, I honestly just plumb forgot to keep them updated. Maybe I should write a script for it? Honestly I really dislike having to maintain classifiers - oh well.

jfhbrook commented 1 year ago

BY THE WAY, I'm absolutely stoked that you're packaging pyee for conda!! That's been on my to-do list for YEARS.

jfhbrook commented 1 year ago

OK neat. I published two new versions for you:

Let me know if you have any other issues!

mxschmitt commented 1 year ago

ha! Python 3.4 was released before I even started with programming.

BY THE WAY, I'm absolutely stoked that you're packaging pyee for conda!! That's been on my to-do list for YEARS.

hehe we use it for Playwright for Python, so I took over maintaining it on conda-forge. Very helpful this package!

Maybe I should write a script for it? Honestly I really dislike having to maintain classifiers - oh well.

Usually I do just search/replace in the code base when I drop an old Python version, seems not worth it writing a script imo.

Thanks again for maintaining it and being responsible!

v11 should be live on conda soon.