search

jfhbrook / pyee

A rough port of Node.js's EventEmitter to Python with a few tricks of its own
https://github.com/jfhbrook/public
MIT License
371 stars 39 forks source link

Automatically create GitHub Release #138

Closed jfhbrook closed 12 months ago

jfhbrook commented 1 year ago

This is an attempt to address #129. I haven't reviewed or tested it, but I think this would be pretty close to working.

My intent is to wait until I do the next pyee release, then self-review and decide if I like it or not.

jfhbrook commented 1 year ago

A suggestion from online was to additionally trigger publishing to pypi. https://x.com/ljharb/status/1713294633676239275

jfhbrook commented 12 months ago

I added steps to publish to PyPI. I also realized that the GitHub release action I was using doesn't support publishing the release, so I refactored to use a different one. Finally, I added a step to attach the builds to the release.

I'm not sure how to QA this aside from merging and going YOLO. Might go and do that? Will probably be a mess.