search

jfilter / react-native-onboarding-swiper

🛳 Delightful onboarding for your React-Native app
https://www.npmjs.com/package/react-native-onboarding-swiper
Other
986 stars 180 forks source link

Feature: keyboard aware scrolling for pages #94

Open rennehir opened 4 years ago

rennehir commented 4 years ago

Awesome library, and it enabled us to build a solid onboarding flow to our application very fast!

But one thing we wanted to do on one of the onboarding screens was to collect the users email address. Overriding the subtitle component via props worked very well here. Problem arised when the keyboard popped up and covered most of the screen, and of course the input component as well.

I forked the repo and made a quick fix using a library called react-native-keyboard-aware-scroll-view. I wrapped the Page component with the KeyboardAwareScrollView and everything works well, at least for our purposes.

I think that this feature could help a lot of other devs as well.

My way of fixing the problem is only one way. One other way for implementing this would be to enable overriding the whole Page component for even more flexibility, but then the users might lose some of the out-of-the-box features like animating the background colors.

@jfilter do you see this as a feature that could be implemented in the library? I am happy to help thinking through the implementation, or even making a proper pull request after agreeing upon the implementation details :)

raquelmsmith commented 2 years ago

@rennehir Just ran into this problem myself. Do you by chance know how I could fix it without forking the library? I like to avoid forking libraries as much as I can so I can easily get updates in the future.

Thanks!

rennehir commented 2 years ago

@raquelmsmith I have continued to use the forked version. At least when we tried, we did not find a workaround without forking.

raquelmsmith commented 2 years ago

Bummer ok. Are you by chance able to share your fork?

rennehir commented 2 years ago

@raquelmsmith here you go: https://github.com/shareway-oy/react-native-onboarding-swiper

We haven't been updating it for over a year, and actually a while ago stopped using the whole library. We implemented our onboarding using react-native-tab-view. Feel free to use our fork or take a look how we solved the problem and make your own.