search

jfindley / newrelic_exporter

NewRelic exporter for prometheus
BSD 2-Clause "Simplified" License
29 stars 20 forks source link

App name as label #3

Closed NightTsarina closed 9 years ago

NightTsarina commented 9 years ago

Instead of putting it in the metric name, make the app a label.

jfindley commented 9 years ago

Sorry for the delay reviewing this, I'm seeing some missing metrics when I test these changes and I'm trying to work out if that's the fault of these changes or not.

One of the metrics that's missing in my tests, for example, is host_count, which appears in the application_summary part of the app list, rather than in the main metric data (see the application_list.json file in _testing).

jfindley commented 9 years ago

Thanks for doing this, and sorry it's taken so long, I've found the root of my issues and they were unrelated, as it turns out.

NightTsarina commented 9 years ago

On 04/08/15 18:00, James Findley wrote:

Thanks for doing this, and sorry it's taken so long, I've found the root of my issues and they were unrelated, as it turns out.

Oh, thanks!

Sorry for not replying to your earlier mail, I just have had no time for verifying that!

Martín Ferrari (Tincho)