In 0.17.0, setting max_results_per_page to 0 or less disabled pagination. The documentation for 1.0.0b1 says this behavior is retained for the new parameter max_page_size, but that does not appear to be the case.
The effect is only achieved by setting page_size=0andmax_page_size=0.
If page_size=-1, we get the error "Page size must be a positive integer".
If page_size=0 and max_page_size=-1, we get the error "Page size must not exceed the server's maximum: -1" even if the request does not specify a page size. This is also true when max_page_size=0 and page_size is anything > 0.
This behavior can be confirmed by looking at _paginated, specifically the conditionals on L1420, L1422, L1428. Compare with _compute_results_per_page from 0.17.0, which has the behavior described in the documentation.
In
0.17.0, settingmax_results_per_pageto0or less disabled pagination. The documentation for1.0.0b1says this behavior is retained for the new parametermax_page_size, but that does not appear to be the case.The effect is only achieved by setting
page_size=0andmax_page_size=0.page_size=-1, we get the error "Page size must be a positive integer".page_size=0andmax_page_size=-1, we get the error "Page size must not exceed the server's maximum: -1" even if the request does not specify a page size. This is also true whenmax_page_size=0andpage_sizeis anything > 0.This behavior can be confirmed by looking at
_paginated, specifically the conditionals on L1420, L1422, L1428. Compare with_compute_results_per_pagefrom0.17.0, which has the behavior described in the documentation.What is the intended behavior?