search

jfinkels / flask-restless

NO LONGER MAINTAINED - A Flask extension for creating simple ReSTful JSON APIs from SQLAlchemy models.
https://flask-restless.readthedocs.io
GNU Affero General Public License v3.0
1.02k stars 301 forks source link

Flask 1.0.2 compatibility #692

Open damahou opened 5 years ago

damahou commented 5 years ago

Flask 1.0.2 doesn't allow dots in Blueprint view functions since commit pallets/flask@2f57a0b917478a028859b9d036b59cf1bba6cad2

As there are some view function names ended with .relationship, Flask-Restless breaks recent versions of Flask . I have changed this names and now they ends with _relationship. It seems to work with Flask 1.0.2. This solves #686.

ajite commented 5 years ago

This works for me with Flask 1.0.2 and Python 3.6.5. Can this be merged?

dakoner commented 5 years ago

Don';t really want to +1, but +1. The examples in the documentation don't even work without this patch.

pawulon commented 5 years ago

I think that similar fix should be applied to eval eval_api_name = '{0}_eval'.format(apiname)

michalkurdziel commented 5 years ago

this will be merged?

sholsapp commented 4 years ago

@jfinkels are you still maintaining this library?

jfinkels commented 4 years ago

No, sorry. I'm afraid I don't have time for it.

On Sat, Mar 28, 2020 at 6:29 PM Stephen Holsapple notifications@github.com wrote:

@jfinkels https://github.com/jfinkels are you still maintaining this library?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jfinkels/flask-restless/pull/692#issuecomment-605528040, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA5XG2B7ELSFR3T3VBCIF3RJZ237ANCNFSM4GDC6NHQ .

sholsapp commented 4 years ago

That's sad to hear. It was a great library. Thanks for building it and maintaining it over the years. :)

Can you mark the library as deprecated somehow? Stuff like that talked about in https://medium.com/maintainer-io/how-to-deprecate-a-repository-on-github-8f0ceb9155e sounds like a decent approach, and similar to what others have been doing.

jfinkels commented 4 years ago

I've left a notice in the GitHub description and the README that I am no longer maintaining this repository. Thanks for the suggestion, and sorry for the inconvenience.

On Mon, Apr 6, 2020 at 12:27 PM Stephen Holsapple notifications@github.com wrote:

That's sad to hear. It was a great library. Thanks for building it and maintaining it over the years. :)

Can you mark the library as deprecated somehow? Stuff like that talked about in https://medium.com/maintainer-io/how-to-deprecate-a-repository-on-github-8f0ceb9155e sounds like a decent approach, and similar to what others have been doing.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jfinkels/flask-restless/pull/692#issuecomment-609898185, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA5XGZUG7YE3I73SPHK2DDRLH7GDANCNFSM4GDC6NHQ .

mrevutskyi commented 4 years ago

Hi, there is a fork project Flask-Restless-NG that has this issue and some other issues fixed, along with performance improvements