search

jfirebaugh / konacha

Test your Rails application's JavaScript with the mocha test framework and chai assertion library
Other
1.05k stars 117 forks source link

Updating out of date railties dependency #200

Closed compwron closed 9 years ago

compwron commented 9 years ago

Also adding Gemfile.lock to prevent local 'The bundle currently has railties locked at 4.1.10' issues

jfirebaugh commented 9 years ago

Thanks for the contribution. I would prefer to test against both 4.1 and 4.2 -- see 2bef6229cb85d2f4692e2bb425498aa7f23ce2ae for how this is done, basically adding a separate Gemfile-rails41 with the contents of the existing Gemfile.

Also, this is a gem, so Gemfile.lock should not be checked in.

compwron commented 9 years ago

How about now? :)

jfirebaugh commented 9 years ago

Thanks, applied as 78ad9039615b243e83ceef8198825e4948805ae5.