search

jfirebaugh / konacha

Test your Rails application's JavaScript with the mocha test framework and chai assertion library
Other
1.05k stars 117 forks source link

Feature/sprockets 23 #206

Closed jonhyman closed 9 years ago

jonhyman commented 9 years ago

Fixes #203

jfirebaugh commented 9 years ago

Awesome!

The build errors on Travis are all LoadError on tilt, stemming from the fact that Sprockets 2 had a dependency on tilt that konacha was implicitly depending on and Sprockets 3 no longer has that dependency. Perhaps we can remove the || Tilt[pathname] condition in the second case. I don't recall exactly what that case is for.

jonhyman commented 9 years ago

So I tried removing Tilt for Sprockets 3 but lots of tests then fail. I also did not run the tests after upgrading to sprockets 3 and after doing so a few minutes ago, this spec fails. Let me work on this a bit more later today, I have to run to a few meetings.

1) Konacha.spec_paths with additional spec directories has specs from app/sections Failure/Error: subject.should include("my_section/my_section_spec.js.coffee") expected

jonhyman commented 9 years ago

@jfirebaugh I added a dependency for tilt and then fixed the spec for Sprockets 3.

jfirebaugh commented 9 years ago

Thanks, nice work! Committed as 82928daf8a2a0917c74eca2f475ba476e5cc03d9.

jonhyman commented 9 years ago

Awesome, thanks!

gabebw commented 9 years ago

Oh man, thank you! This is great news!