search

jfirebaugh / konacha

Test your Rails application's JavaScript with the mocha test framework and chai assertion library
Other
1.05k stars 117 forks source link

Add Support for Sprockets 3.0 #217

Closed alexkravets closed 8 years ago

jfirebaugh commented 8 years ago

Thanks @alexkravets. Where does this stand with respect to https://github.com/jfirebaugh/konacha/issues/216#issuecomment-178960198?

alexkravets commented 8 years ago

@jfirebaugh no backward compatibility for sprockets-rails < 3.0. So seems like Rails 4.1 is not an option, as that one has sprockets-rails ~> 2.0. Correct me if I'm wrong.

jfirebaugh commented 8 years ago

Ok, I can't accept this PR as-is then. Konacha needs to maintain compatibility with Rails 4.1.

alexkravets commented 8 years ago

@jfirebaugh do you want me to bump version?

jfirebaugh commented 8 years ago

@alexkravets Which version are you referring to?

alexkravets commented 8 years ago

@jfirebaugh we can bump konacha major version, so for Rails 4.1 support you would need to keep the current one locked.

jfirebaugh commented 8 years ago

No -- I want to maintain Rails 4.1 and sprockets 2 support:

alexkravets commented 8 years ago

@jfirebaugh we have no interest to do that.

jfirebaugh commented 8 years ago

Ok, sorry but I can't accept this PR in that case.

alexkravets commented 8 years ago

No problem.

rafamanzo commented 8 years ago

@alexkravets I hope you don't mind but I've made a patch that adds the conditionals for sprockets 3 API and undo konacha.gemspec modifications: https://gist.github.com/rafamanzo/4deafb6546ffd350a689

I hope you can apply it, so @jfirebaugh can reopen and accept this. It you are really not interested on it, do you mind if a open a new PR with such changes?

Thanks!

alexkravets commented 8 years ago

@rafamanzo new pull request has been created: https://github.com/jfirebaugh/konacha/pull/219 — with your patch applied, thanks!

@jfirebaugh please take a look, now this should be good to go!