jfischoff / hs-cmdstan

Haskell CmdStan Wrapper
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Added optional to fix parsing of input files #5

Closed adamConnerSax closed 3 years ago

adamConnerSax commented 3 years ago

StanSummary in v2.26.1 drops the first line of the summary output, the one reading "input files: ...". I've opened an issue there (https://github.com/stan-dev/cmdstan/issues/988) in case it was unintentional.

In the meantime, this PR makes parsing that line optional and returns an empty list of input files if the line is missing. You could also change the structure of the summary to use Maybe [FilePath] but I wanted to make the smallest possible change.

jfischoff commented 3 years ago

Thanks @adamConnerSax