jfitzell / mozilla-keychain

Store your Firefox website usernames and passwords in Apple's Keychain Services, just like Safari and other browsers do on OS X.
55 stars 9 forks source link

Interferes with Xmarks-Addon #9

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Select Tools|Xmarks|Xmarks Settings...
2. Enter username, password and check "Remember this password between sessions"
3. Click "Synchronize Now" button
4. The synchronization fails
5. Closing and reopen the settings dialog -> password field is empty
6. Enter password and uncheck "Remember this password between sessions"
7. Click "Synchronize Now" button
8. The synchronization succeeds

What is the expected output?

Synchronization succeeds and password can be reread through the keychain addon.

What do you see instead?

Synchronization fails. It seems that the password cannot be reread through
the keychain addon. Although it was correctly saved in keychain. In my
keychain I find a entry with name "login.xmarks.com (username)", url
"http://login.xmarks.com" where username and password are correctly set.

What version of the product are you using? On what operating system?

- Firefox 3.5.3
- mozilla-keychain 1.0a7
- Mac OS X 10.6.1

Original issue reported on code.google.com by google.m...@spamgourmet.com on 23 Sep 2009 at 3:10

GoogleCodeExporter commented 9 years ago
You should try 1.0b1 if you haven't already... there were similar issues with 
another addon that were fixed 
possibly in that version.

That said, this doesn't entirely surprise me as I haven't tested it at all with 
anything except web pages. It 
would help me track this down if you can provide some logging information:

+ go to about:config
+ set the signon.debug option to true
+ quite firefox
+ Run Firefox from the command line by opening Terminal.app and then running 
Firefox (probably 
/Applications/Firefox.app/Contents/MacOS/firefox-bin)
+ go through the steps you went through above
+ send me the log output to the terminal

Original comment by jfitz...@gmail.com on 25 Sep 2009 at 9:12

GoogleCodeExporter commented 9 years ago
I tried the same with 1.0b1. This time I deleted all saved xmarks passwords in
Firefox' password manager and the Keychain before testing. So I realized the 
password
was never saved in the keychain. The keychain entry I mentioned above, 
obviously was
already there from a previous login to their webpage.

What steps will reproduce the problem?
1. Select Tools|Xmarks|Xmarks Settings...
2. Enter username, password and check "Remember this password between sessions"
3. Click "Synchronize Now" button
4. Firefox' password manager asks for master password
5. Password is successfully saved in Firefox' password manager

What version of the product are you using? On what operating system?

- Firefox 3.5.3
- mozilla-keychain 1.0a7
- Mac OS X 10.6.1

Version 1.0b1 works definitely better. Looking at the log I would say the
mozilla-keychain tries to save the password but fails because of the uri is
malformed. And so Firefox' password manager saves the password instead.

Original comment by google.m...@spamgourmet.com on 26 Sep 2009 at 12:41

Attachments:

GoogleCodeExporter commented 9 years ago
By the way. The Xmarks plugin for Safari saves its password as an application
password in the keychain. Would it be possible to save passwords with malformed 
uri
as application passwords in keychain? 

Original comment by google.m...@spamgourmet.com on 26 Sep 2009 at 12:56

GoogleCodeExporter commented 9 years ago
Yes, your analysis is correct and that's what I suspected the problem would be.

And yes, my intended solution is to store them as application passwords, but it 
requires implementing a different 
set of APIs and I haven't got around to it yet. I created an enhancement 
request for clarity in Issue 10 and I'll 
mark this as a duplicate of that one.

Original comment by jfitz...@gmail.com on 26 Sep 2009 at 8:18

GoogleCodeExporter commented 9 years ago
Thanks! :-)

Original comment by google.m...@spamgourmet.com on 27 Sep 2009 at 12:56