jflamy / owlcms4

Olympic Weightlifting Competition Management System
https://owlcms.github.io/owlcms4/#/index
Other
60 stars 20 forks source link

Running Sinclair meet settings only on non bodyweight groups #690

Open gal432 opened 1 year ago

gal432 commented 1 year ago

Is your feature request related to a problem? Please describe. We had some inconsistent behaviors on athlete ranks when running two groups, one with bodyweight categories and one with not, while the Sinclair meet settings were turned on. We wanted that the Sinclair meet settings will be on only for the non-bodyweight groups.

Describe the solution you'd like Only the non-bodyweight groups will be considered in a Sinclair meet setting while the groups with bodyweight categories will be considered in regular competitions. Another suggestion is that the Sinclair Meet setting will be configured per group.

Describe alternatives you've considered Ran two competition systems together

Additional context See that the non-bodyweight groups don't have the first rank: image The Top Sinclair shows the same athlete twice image

jflamy-dev commented 1 year ago

Currently these settings are the competition level and not at the group level because of the end-of-competition documents. Y You would in effect produce two end-of-competition kits -- you can't mix and match the points per age group with Sinclair-only points, etc.

So running two competitions is indeed the easiest option. If running locally you can easily switch from one to another using the same network address the browsers will automatically detect that a new server is there and resync.

When running locally, you can pass as a variable to java -DJDBC_DATABASE_URL=jdbc:h2:file:./database/databaseBmv.db (on Windows, copy the owlcms.exe file rename it owlcmsB.exe and copy the owlcms.l4j.ini file to owlcms4B.l4j.ini and add the option inside the file).

I have kept the suggestion open in case I one day redo things differently.

gal432 commented 1 year ago

Maybe I am just confused, but why can't we manage the Sinclair Meet feature on the group level. E.g. image

jflamy commented 1 year ago

What you are proposing would be sort of a Masters groups age 0-129 with all ages having the same age coefficient (or you may actually apply the age coefficients to put older athletes on the same footing)

That might work, as long as you don't care about team points - then you have to run separate competitions.

gal432 commented 1 year ago

All athletes under 22 will be in groups with bodyweight categories. All older people will be in a Sinclair meet based on gender

I don't care about team points in this kind of competition.

jflamy commented 1 year ago

Then create yourself a M22 and F22 Masters age groups, ending at age 99 and only enable these two as Masters.

The age coefficients start very gently at 30 so you might just declare that it's SMF-rated and make it more enteraining as oldies can challenge young guns. Otherwese, you would override the properties file in local/sinclair/sinclair2020.properties and put 1.0 on all the SMF and SMHF coefficients.

But I don't have a way to remove a brilliant 19 year-old sinclair from the rankings.

gal432 commented 1 year ago

Do Masters competitors rank based on Sinclair? Because I don't see the ranks getting updated after I re-assigned these groups to be masters.

image
jflamy-dev commented 1 year ago

The Masters formula is a Sinclair(weight,sex) * AgeFactor(age,sex) Within an age group they normally do show ranks based on total. But for the full competition there is the SMM report.

For all groups in the competition it would be conceivable to add the SMM value and SMM rank as additional columns But it would be global for the full competition, because it would be controlled by the style sheet. But since it is one competition, it is one SMM ranking, and one style sheet.

On Thu, Jun 15, 2023 at 1:54 PM gal432 @.***> wrote:

Masters competitors ranks based on Sinclair?

— Reply to this email directly, view it on GitHub https://github.com/jflamy/owlcms4/issues/690#issuecomment-1593500702, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM2PAKI7CZBUDC7VHIKU2CTXLND35ANCNFSM6AAAAAAZH72LRQ . You are receiving this because you commented.Message ID: @.***>

-- Jean-François Lamy

gal432 commented 1 year ago

So what about adding Competition type: Sinclair? that could be an easy solution for that, isn't it?

jflamy commented 1 year ago

Doing more discussing: The more general request is to show a global score and a global rank.

There are four such scores in common use, The application currently computes all four of them.

  1. Sinclair,
  2. Sinclair computed at category weight,
  3. SM(H)F and
  4. Robi.

So it is conceivable to add a competition-wide global ranking to be shown on a scoreboard. The global ranking would be computed for all athletes but only shown on some session scoreboards. Eventually, there could be a flag to exclude athletes from the global score and rank.

So there could be the regular scoreboard and the global score scoreboard, the latter would also have the global score and rank (but likely not show the best weight and per-lift ranking).

But contrary to your image above, this would be a feature for a session, not an age group, and it could be a manual switch between scoreboards if push comes to shove.

jflamy-dev commented 1 year ago

(The fifth type of Global Score is % of a given record). That's also been requested.

On Thu, Jun 15, 2023 at 2:51 PM Jean-François Lamy @.***> wrote:

Doing more discussing: The more general request is to show a global score and a global rank.

There are four such scores in common use, The application currently computes all four of them.

  1. Sinclair,
  2. Sinclair computed at category weight,
  3. SM(H)F and
  4. Robi.

So it is conceivable to add a competition-wide global ranking to be shown on a scoreboard. The global ranking would be computed for all athletes but only shown on some session scoreboards. Eventually, there could be a flag to exclude athletes from the global score and rank.

So there could be the regular scoreboard and the global score scoreboard, the latter would also have the global score and rank (but likely perhaps not show the best weight and per-lift ranking).

But contrary to your image above, this would be a feature for a session, not an age group, and it could be a manual switch between scoreboards if push comes to shove.

— Reply to this email directly, view it on GitHub https://github.com/jflamy/owlcms4/issues/690#issuecomment-1593567305, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM2PAKL5HHUVDSJNYKZFZODXLNKTPANCNFSM6AAAAAAZH72LRQ . You are receiving this because you commented.Message ID: @.***>

-- Jean-François Lamy

gal432 commented 1 year ago

Usually in our usage we are configuring the groups every event