search

jflancer / bigballR

Package for working with NCAA Basketball Data
Other
61 stars 19 forks source link

Duplicate ID in teamids #11

Closed lucaswu17 closed 3 years ago

lucaswu17 commented 3 years ago

Hey Jake,

Great work on the package! I found that there are a few teams with duplicated IDs in the teamids dataframe. I'm wondering are those typos?


library(bigballR)
library(dplyr)

> teamids %>% count(ID) %>% filter(n > 1)
# A tibble: 3 x 2
      ID     n
   <dbl> <int>
1  14759     2
2 486932     2
3 505512     2
> duplicate_ids = teamids %>% count(ID) %>% filter(n > 1) %>% pull(ID)
> teamids %>% filter(ID %in% duplicate_ids)
# A tibble: 6 x 4
  Team             Conference     ID Season 
  <chr>            <chr>       <dbl> <chr>  
1 Temple           AAC         14759 2012-13
2 TCU              Big 12      14759 2012-13
3 Nevada           MWC        486932 2019-20
4 Loyola Marymount WCC        486932 2019-20
5 Troy             Sun Belt   505512 2020-21
6 Tulane           AAC        505512 2020-21
jflancer commented 3 years ago

Hey Lucas - they are typos that I've resolved. If you install the package again the ids dataset should be fixed.