search

jflancer / bigballR

Package for working with NCAA Basketball Data
Other
61 stars 19 forks source link

update for 2022-23 season #29

Closed evanmiyakawa closed 1 year ago

evanmiyakawa commented 1 year ago

This update updates data/teamids.Rdata to include teamids for 2022-23, adds new D1 teams, changes team conferences based on conference movement, and renames some teams to match modified team names used by NCAA.com. For example, Incarnate Word has changed everywhere to UIW, which is now reflected for all occurrences of Incarnate Word in the teamids object.

I'll wait to submit this PR until box and pbp ids are available for the first day of games to make sure that day schedules and team schedules can be scraped correctly.

jrbarber37 commented 1 year ago

Will similar changes also be made to wbigballR?

Thanks John Barber

On Tue, Oct 18, 2022 at 7:36 PM Evan Miyakawa @.***> wrote:

This update updates data/teamids.Rdata to include teamids for 2022-23, adds new D1 teams, changes team conferences based on conference movement, and renames some teams to match modified team names used by NCAA.com. For example, Incarnate Word has changed everywhere to UIW, which is now reflected for all occurrences of Incarnate Word in the teamids object.

I'll wait to submit this PR until box and pbp ids are available for the first day of games to make sure that day schedules and team schedules can be scraped correctly.

You can view, comment on, or merge this pull request online at:

https://github.com/jflancer/bigballR/pull/29 Commit Summary

File Changes

(2 files https://github.com/jflancer/bigballR/pull/29/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/jflancer/bigballR/pull/29, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUIJZH477G7CQYD2F47DQK3WD4X65ANCNFSM6AAAAAARISHCXM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

evanmiyakawa commented 1 year ago

Will similar changes also be made to wbigballR? Thanks John Barber … On Tue, Oct 18, 2022 at 7:36 PM Evan Miyakawa @.> wrote: This update updates data/teamids.Rdata to include teamids for 2022-23, adds new D1 teams, changes team conferences based on conference movement, and renames some teams to match modified team names used by NCAA.com. For example, Incarnate Word has changed everywhere to UIW, which is now reflected for all occurrences of Incarnate Word in the teamids object. I'll wait to submit this PR until box and pbp ids are available for the first day of games to make sure that day schedules and team schedules can be scraped correctly. ------------------------------ You can view, comment on, or merge this pull request online at: #29 Commit Summary - c37f844 <c37f844> update for 2022-23 season File Changes (2 files https://github.com/jflancer/bigballR/pull/29/files) - M R/all_functions.R https://github.com/jflancer/bigballR/pull/29/files#diff-53bf0eed3ceb0feaf6b9611ca3a60b4e809ff238786fd2297d9ac6c2ed0e5222 (3) - M data/teamids.RData https://github.com/jflancer/bigballR/pull/29/files#diff-aa9775826b5b0b91cdf3ce854bba679ce4e3feacc653fc48ce3548433de4ba71 (0) Patch Links: - https://github.com/jflancer/bigballR/pull/29.patch - https://github.com/jflancer/bigballR/pull/29.diff — Reply to this email directly, view it on GitHub <#29>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUIJZH477G7CQYD2F47DQK3WD4X65ANCNFSM6AAAAAARISHCXM . You are receiving this because you are subscribed to this thread.Message ID: @.>

https://github.com/jflancer/wbigballR/pull/5