Named entity strings added to AMR in wrong order?

jflanigan / jamr

JAMR Parser and Generator

BSD 2-Clause "Simplified" License

193 stars 50 forks source link

Named entity strings added to AMR in wrong order? #20

Open nschneid opened 7 years ago

nschneid commented 7 years ago

One of my students ran some test sentences through JAMR, and we noticed that multiword named entities (possibly just out-of-vocabulary ones) were represented backwards. E.g., with "John Smith" as the input, the resulting AMR was

(p / person 
    :name (n / name 
        :op1 "Smith" 
        :op2 "John"))

Is this due to a bug in the NER heuristics?

nschneid commented 7 years ago

Looks like unnumbered :ops are constructed in https://github.com/jflanigan/jamr/blob/b40c241225d9dcddcf9d27dfccd84bd73b8ef628/src/ConceptInvoke/Concepts.scala#L66 and the numbers are added in https://github.com/jflanigan/jamr/blob/b40c241225d9dcddcf9d27dfccd84bd73b8ef628/src/Graph.scala#L501

nschneid commented 7 years ago

Maybe this was fixed in the Semeval-2016 branch by a377c14