jflieben / assortedFunctionsV2

Other
23 stars 1 forks source link

Failed to add Channel XXXX with URL #9

Closed Apoc70 closed 3 hours ago

Apoc70 commented 4 hours ago

The module fails to add channels with Smiley characters as the first character. This seems to be a PnP-module error. Maybe the module can catch this error?

image

jflieben commented 3 hours ago

@Apoc70 thanks for reporting! I just quickly tried to reproduce this, but the emoticon doesn't render in my teams client:

image

How did you get that emoticon in the channel name / how can I reproduce?

edit: found it, windows + . reproducing now

jflieben commented 3 hours ago

hmm no issue here, but maybe because I added the emoticon post-creation: image I'll try another few

jflieben commented 3 hours ago

@Apoc70 still unable to reproduce, works fine here.....do those channels/sites still exist? Maybe they were deleted or something else?

jflieben commented 3 hours ago

ok, tried deleting the underlying sharepoint site of one of those channels (without deleting the channel) and got the exact same error as you're seeing above:

Write-Error: Failed to add Channel 🤣👍 two emoticons then with URL https://lieben.sharepoint.com/sites/TestSpoPerms2-twoemoticonsthen to scan list because Get-PnPTenantSite failed with Cannot get site https://lieben.sharepoint.com/sites/TestSpoPerms2-twoemoticonsthen.

I think that means we can close this with 'it's a feature', let me know if you disagree or if your situation is different and feel free to reopen.

Apoc70 commented 3 hours ago

@jflieben There is a different reason. PnP tries to access https://TENANT.sharepoint.com/**sites**/SITENAME which results in a 404 error.

The correct URL is https://TENANT.sharepoint.com/**teams**/SITENAME

jflieben commented 3 hours ago

@Apoc70 thanks! That got me on the right track, as my and my customer's envs don't use that /teams/ url component I hardcoded /sites/. Fixed here: https://github.com/jflieben/assortedFunctionsV2/commit/6b0ea22b73bbc92992454122d4c794a3fd209853#diff-65d070bda006e76f0e91d92b028e6544af8a38b7a5b26dd8d3f36ed58ceeb48cR86

It'll be included in v1.0.4!