search

jflinter / Dwifft

Swift Diff
MIT License
1.86k stars 147 forks source link

Fix warnings for Xcode 12, when used from SPM #102

Open DenTelezhkin opened 4 years ago

DenTelezhkin commented 4 years ago

SPM in Xcode 12 bumps minimum iOS deployment target to iOS 9, which produces warnings when trying to use Dwifft.

This PR fixes that by deleting minimum supported platforms from Package.swift. Please note, that macOS platform stays, because Dwifft minimum requirement for MacOS is higher than SwiftPM minimum deployment target.

I've also fixed couple new warnings from Swift compiler and enabled building for watchOS.

Pe-te commented 3 years ago

Hi, I also get the enum warning you fixed and some other warnings for public modifer:

/Pods/Dwifft/Dwifft/Dwifft.swift:312:5: 'public' modifier is redundant for instance method declared in a public extension /Pods/Dwifft/Dwifft/Dwifft.swift:318:5: 'public' modifier is redundant for instance method declared in a public extension /Pods/Dwifft/Dwifft/SectionedValues.swift:75:5: 'public' modifier is redundant for initializer declared in a public extension

Maybe you can add those too?

And do you know what's needed to get the PR merged and deployed in a new version?

DenTelezhkin commented 3 years ago

It's up to maintainer @jflinter I guess. As for the warnings you are mentioning, they are already fixed on master branch.