jflucier / ILL_pipelines

Isabelle Laforest-Lapointe Laboratory code
0 stars 1 forks source link

first commit #32

Closed jorondo1 closed 2 years ago

jorondo1 commented 2 years ago

let me know if I did right...?!

jflucier commented 2 years ago

looks good!

va merger ca plus tard et closer ce ticket ensuite

jorondo1 commented 2 years ago

cool merci je l'ai pas testé parce q ue c'est assez basic, mais est-ce ok si aucun argument n'est donné?

jflucier commented 2 years ago

done

https://github.com/jflucier/ILL_pipelines/commit/e9d8e358ccb94714f4d7c4f93cbfd231b551ed79

tu as defini dasn my config, ca devrait etre ok.

faudrait que jajoute validation que variable existe

jflucier commented 2 years ago

added validaiton

https://github.com/jflucier/ILL_pipelines/commit/b0681f11ec203a0a77b5253850c8f2a0a2fcd7b4

jflucier commented 2 years ago

joubliais...

jai delete la branche iss-slurm_email

tu dois te recreer un branche a partir de main avant de refaire des changements / fix

git branch new_branch_name
git checkout new_branch_name
jorondo1 commented 2 years ago

yes c'est bien ce que j'ai fait, en gros:

git checkout -b iss-slurm_email # branche mon code

# changer mes affaires

git add .
git commit -m 'message'
git push origin iss-slurm_email
jflucier commented 2 years ago

oui mais la tu dois faire

git checkout main
git pull origin main
git branch new_branch_name
git checkout new_branch_name