search

jflyper / cleanflight

Clean-code version of the baseflight flight controller firmware
http://cleanflight.com
GNU General Public License v3.0
0 stars 1 forks source link

Split OLED displayport out of dashboard #3

Closed martinbudden closed 7 years ago

martinbudden commented 7 years ago

I've split the OLED displayport code out of dashboard.c. As part of that I've changed the dashboardCmsInit code, but I haven't got a wired up OLED display at the moment, so I haven't been able to test that. It should be fine, bug could you just check it before you merge?

I've also made a bunch of functions and variables in cms.c static.

martinbudden commented 7 years ago

I've had some further thoughts on canvas.c. As I said before, this is too generic a name. It's a displayport over the MW_OSD using the MSP_CANVAS command. So how about renaming the file displayport_mw_osd_canvas.c (and similarly for the .h file)?

Likewise I think we should rename osd_max7456.c to displayport_max7456.c

jflyper commented 7 years ago

How about displayport_mspserial, for "display port over msp over serial". In this scheme, we will have displayport_oled.[ch] displayport_osd7456.[ch] displayport_mspserial.[ch] displayport_mspsport.[ch]

I would also like to rename osd.[ch] to osd7456.[ch].

jflyper commented 7 years ago

For the file organization, there is a lot of cms_xxx.[ch] in io. My original intension during separation was to merge contents of these files to relevant files that each config variable (or variable group) is defined so mods to config variable and associated CMS menu can be done within the files, but it may obscure the essentials of the files at the same time.

Keeping cms_xxx files as they are may be the best practice at the moment. Create a cms directory under io or main, perhaps?

martinbudden commented 7 years ago

Create a cms directory under io or main, perhaps?

Yes, I was going to suggest the same. Under main, I think. But don't do any changes along that nature yet - I've got a couple of PRs I'd like to submit first. Then, at the end, we can reorganise the files.