search

jflyper / cleanflight

Clean-code version of the baseflight flight controller firmware
http://cleanflight.com
GNU General Public License v3.0
0 stars 1 forks source link

CMS file renaming. displayPort renaming #5

Closed martinbudden closed 7 years ago

martinbudden commented 7 years ago

OK, here's the big renaming. Main change is the creation of the CMS directory and the moving of the files there. Also menu files have menu explicitly in their name.

I've also renamed displayOpen and displayClose to displayGrab and displayRelease since that is a more accurate representation of what the CMS is doing - it's temporarily grabbing a display that belongs to something else.

MSP_CANVAS is now MSP_DISPLAYPORT.

FEATURE_CANVAS is now FEATURE_MSP_OSD

The CANVAS build flag is now USE_MSP_DISPLAYPORT

jflyper commented 7 years ago

I'm not so sure about the mismatch between FEATURE_MSP_OSD and USE_MSP_DISPLAYPORT/MSP_DISPLAYPORT.

martinbudden commented 7 years ago

Yes, I'm not entirely sure about that either.

jflyper commented 7 years ago

I'll push it anyways and think it over my pillow, probably from the perspective of a user with a serially connected osd who types this name in cli (or enables it in the configurator).

BTW, displayGrab and displayRelease sounds really good!

jflyper commented 7 years ago

FEATURE_MSP_DISPLAYPORT, with cli feature parameter MSP_DISPLAYPORT would be my choice for the following reasons.

  1. MSP_OSD as a prefix is already taken (e.g., MSP_OSD_CONFIG, MSP_OSD_CHAR_READ, ...).
  2. Like wise, it makes me recollect something controlling OSD.
martinbudden commented 7 years ago

I'm happy with that - go ahead and make the change.