" 'DEBUG' in os.environ " expression always return 'True'

jfmatth / openshift-django17

Running django 1.7 apps on Red Hat's Openshift 2 DEPRECATED

MIT License

72 stars 25 forks source link

" 'DEBUG' in os.environ " expression always return 'True' #13

Closed caitong93 closed 9 years ago

caitong93 commented 9 years ago

In setting.py DEBUG = DEBUG or 'DEBUG' in os.environ which should be DEBUG = DEBUG orDEBUGin os.environ and os.environ['DEBUG'] ==True``

jfmatth commented 9 years ago

HI Caitong93, thanks for having a look at my repo.

I'm not sure I see any improvement in your logic vs. mine? The only different seems to be that DEBUG should be the string "True" but with mine, it could be anything, as long as it just exists in the environment.

If you'd like to show me some examples and submit a pull request, i'll consider it.

thanks again,

John

caitong93 commented 9 years ago

Oh, I misunderstood it.After first push, I set DEBUG to 'False' attempting to disable debug...Actually, I can delete that..Forget it.. And, thanks for your repo, great help!

jfmatth commented 9 years ago

No worries.

Thanks for the appreciation.

I'm going to start a branch for v1.8 beta that was just announced, and incorporate my other issues into that branch.