search

jfmatth / openshift-django17

Running django 1.7 apps on Red Hat's Openshift 2 DEPRECATED
MIT License
72 stars 25 forks source link

changed WSGI_APPLICATION as per issue 11 #14

Closed niallrobinson closed 9 years ago

niallrobinson commented 9 years ago

I am open to pull requests.

Good - here you go. I have no idea what I'm doing and am a total django n00b, but it screwed me up and i just followed the directions on issue #11

jfmatth commented 9 years ago

Thanks for submitting,

I'm gong to run some tests first and see what this does. Honestly, your logic may not work, since the WGSI app I'm using when "ON PAAS" is not the one you listed.

Also, if you lookup the definition of this setting, it's only used by the runserver command by manage.py, so I"m thinking I'll just remove it all together.

Thanks,

John

jfmatth commented 9 years ago

Also, don't feel like a n00b, we all start somewhere, and thank goodness for Github that makes it easy.

J

awwong1 commented 9 years ago

Haha, I should have made a pull request a while ago.

The WSGI_APPLICATION definition in the settings file is invalid, just delete the line.

'mysite.wsgi.application' throws an import error, always.

By default, it's set to None. In a development environment, this will resort to using Django's built in WSGI application. This allows you to use the manage.py runserver command. https://docs.djangoproject.com/en/1.7/ref/settings/#wsgi-application

On Openshift, we explicitly define the WSGI Application using the environment variable. https://developers.openshift.com/en/python-environment-variables.html Having the WSGI_APPLICATION set while running on Openshift's PAAS won't effect anything. (Confirmed, as I made that change on my setup a while ago)

niallrobinson commented 9 years ago

Hi guys - just nuked the line altogether. I found both approaches did the trick when I tried on my machine.

jfmatth commented 9 years ago

Niall, thanks for confirming. I'll try to get to the change this week.

J

On Mon, Mar 2, 2015 at 3:40 AM, Niall Robinson notifications@github.com wrote:

Hi guys - just nuked the line altogether. I found both approaches did the trick when I tried on my machine.

— Reply to this email directly or view it on GitHub https://github.com/jfmatth/openshift-django17/pull/14#issuecomment-76698055 .