search

jfmdev / ngComboDatePicker

Angular directive to select dates using combo boxes
Mozilla Public License 2.0
23 stars 20 forks source link

add place-holder-enabled #24

Closed baov closed 7 years ago

baov commented 7 years ago

Allow user to select placeholder value

baov commented 7 years ago

Hello @jfmdev can you check my PR ? Have a nice day :)

alismart commented 7 years ago

Hello @baov Is this directive compatible with angular2? I couldn't manage to install it on my angular2 project..

jfmdev commented 7 years ago

Hi @alismart, Unfortunately, this directive is not compatible with Angular 2. It's on the roadmap, but I can't give you a date. Regards

jfmdev commented 7 years ago

Hello @baov
Before merging your PR I have a question:

Why do you need a parameter for enable/disable the placeholder?

I mean, if you don't want to use the placeholder, you just can give an empty value to ng-placeholder. I can't come up with an scenario in which you will need to enable/disable a placeholder in runtime.

Regards

Yanntr commented 7 years ago

Hello @jfmdev,

This new parameter enable/disable the selection of the placeholder in runtime.

It can be usefull if you use this directive in a search form. With this parameter enabled, the user can revert his selection in order to remove this criteria if he wants to. Without this parameter, he must reload the page.

Regards

PS : I'm working with @baov